Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix irreproducible inference due to the imprecise floating point values in xgboost's get_dump #500

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix irreproducible inference due to the imprecise floating point values in xgboost's get_dump #500

wants to merge 4 commits into from

Conversation

pltb
Copy link

@pltb pltb commented Jul 23, 2024 •
edited
Loading

Tries to address the issues of using the output of the get_dump method in xgboost as the import format by parsing the output of save_model instead

More context here #497

TODO:

  • parse using ObjectParser
  • add more tests
  • review from the plugin's authors

@pltb pltb mentioned this pull request Jul 23, 2024
Open
@pltb pltb changed the title [DRAFT] fix xgboost import [DRAFT] Allow loading xgboost models from the json output of the save_model method Jul 23, 2024
@pltb pltb changed the title [DRAFT] Allow loading xgboost models from the json output of the save_model method Fix irreproducible inference due to the imprecise floating point values in xgboost's get_dump Jul 30, 2024
@pltb pltb marked this pull request as ready for review July 30, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pltb