-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial working Nutanix IPAM CAPI provider #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
requested review from
mhrabovcin,
tuxtof,
thunderboltsid and
yannickstruyf3
August 1, 2024 10:32
jimmidyson
force-pushed
the
jimmi/initial-implementation
branch
from
August 1, 2024 10:38
b070567
to
ab43141
Compare
jimmidyson
changed the title
feat: Initial working Nutanix IPAM CAPI provider*
feat: Initial working Nutanix IPAM CAPI provider
Aug 1, 2024
jimmidyson
force-pushed
the
jimmi/initial-implementation
branch
from
August 1, 2024 10:40
ab43141
to
35a0611
Compare
jimmidyson
force-pushed
the
jimmi/initial-implementation
branch
from
August 1, 2024 11:25
5d2410a
to
db592c5
Compare
thunderboltsid
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a good starting point. We should note the inline comments for future and fix them in later PRs.
Are we planning on open sourcing this operator or will it remain internal?
yannickstruyf3
approved these changes
Aug 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.