forked from atom/teletype-server
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: remove pusher.com dependency - Merged #1
Merged
nonameentername
merged 16 commits into
nonameentername:private-solution
from
adamlwgriffiths:private-solution
Jan 4, 2021
Merged
RFE: remove pusher.com dependency - Merged #1
nonameentername
merged 16 commits into
nonameentername:private-solution
from
adamlwgriffiths:private-solution
Jan 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to latest patch version of Express 4.15.x
Upgrade dependencies to address `npm audit` findings
When running tests from the teletype package we instantiate a test server to assert the end to end integration between client and server. This is problematic on Electron v3 because of a crash that happens due to the bugsnag module. Since this feature is not necessary in tests we decided to allow disabling it to work around the problem. Refs: atom/teletype#438 Co-Authored-By: Antonio Scandurra <[email protected]>
Add flag to disable bugsnag on the test server.
Removes `client_id` and `client_secret` query params from auth headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged version of atom#50.
Regenerated packages-lock.json.
There were a number of broken, deprecated, or vulnerable packages previously.
Server runs, but have not tested with client as I don't have GH OAuth setup nor the custom CRDT / Client installed.