Fixes tests after refactor of fileformats.generic.File into BinaryFile and UnicodeFile
#764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le and UnicodeFile
tclose
changed the title
fileformats.generic.File into BinaryFile and UnicodeFile
tclose
changed the title
fileformats.generic.File into BinaryFile and UnicodeFilefileformats.generic.File into BinaryFile and UnicodeFile
|
@djarecka this is just a minor PR that needs to merged in for the master branch to pass the tests. Do you mind if I do it myself? The only changes are cleaning up some typing and the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
Update to the
fileformatsdependency to add support for static type checking broke a couple of tests (not the code-base itself). This PR fixes those tests.Checklist