backport fix copy of dseg.tsv following templateflow update for LTS #421
Conversation
| dseg_tsv = str( | ||
| api.get('fsaverage', hemi=None, atlas=None, suffix='dseg', extension=['.tsv']) | ||
| ) | ||
| _copy_any(dseg_tsv, | ||
| str(Path(output_dir) / 'smriprep' / 'desc-aseg_dseg.tsv')) | ||
| _copy_any(dseg_tsv, |
There was a problem hiding this comment.
We'll need an associated PR against the fMRIPrep LTS branch. At least the Docker container pins the specific templateflow version, so this line either needs to be one that works for versions 0.7.1 and 24.1.0 or we'll need to check the version.
https://github.com/nipreps/fmriprep/blob/maint/20.2.x/docker/files/environment.yml#L202
There was a problem hiding this comment.
Given that the valid query parameters changed in 24.1, I don't think we can do this reliably across versions with a single command. I would suggest for the LTS:
dseg_LUTs = api.get(OLD_PARAMS)
if isinstance(dseg_LUTs, list):
dseg_LUTs = api.get(NEW_PARAMS) # Requires tf 24.1+
if isinstance(dseg_LUTs, list):
dseg_LUTs = dseg_LUTs[0]
dseg_tsv = str(dseg_LUTs)
|
I am not sure why both files are present in templateflow/tpl-fsaverage. Is that because of CI cache/precomputed inputs ? |
|
TBH, I'm not sure. I think we need to hack around it in any case. @oesteban You might know off the top of your head why this happens? |
No description provided.