Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): navbar examples #1269

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Conversation

tianenpang
Copy link
Member

Closes #1240

📝 Description

  • Avatar rendered as a button.
  • Remove NavbarItem to get cleaner dom.
  • NavbarContent rendered as a div since its child are not list items.

💣 Is this a breaking change (Yes/No):

No.

📝 Additional Information

  • Sync example and code for controlled menu section.
  • Update navbar's stories.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

⚠️ No Changeset found

Latest commit: 1317463

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 4, 2023

@tianenpang is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v1 ❌ Failed (Inspect) Aug 4, 2023 5:38pm

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, well done! @tianenpang 🚀

@jrgarciadev jrgarciadev merged commit 5064bfe into nextui-org:main Aug 4, 2023
6 checks passed
@tianenpang tianenpang deleted the fix/navbar branch August 4, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Component -Navbar with Avatar
2 participants