Skip to content

Commit

Permalink
fix(select): prevent select from closing instantly when clicking on l…
Browse files Browse the repository at this point in the history
…abel of select (#3568)

* fix(select): prevent select from closing instantly when clicking on label

* fix(select): flickering on label click

* fix(select): flickering while click on label

* fix(select): add changeset on fixing the flickering model issue

* chore(changeset): revise changeset message and add issue number

---------

Co-authored-by: WK Wong <[email protected]>
  • Loading branch information
sohan01fw and wingkwong committed Sep 5, 2024
1 parent eda316a commit 5c8cc7a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/clean-dryers-notice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/select": patch
---

Fixed toggle issue while clicking on label of select component unexpectedly open and close the model instantly. The removal of code block containing `group-data-[filled=true]:pointer-events-auto` prevent from any unwanted user interactions and resolve the flickering issue (#3558)
7 changes: 0 additions & 7 deletions packages/core/theme/src/components/select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -535,13 +535,6 @@ const select = tv({
trigger: "h-16 min-h-16 py-2.5 gap-0",
},
},
// labelPlacement=[inside, outside]
{
labelPlacement: ["inside", "outside"],
class: {
label: ["group-data-[filled=true]:pointer-events-auto"],
},
},
{
labelPlacement: "outside",
isMultiline: false,
Expand Down

0 comments on commit 5c8cc7a

Please sign in to comment.