Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prerender property to site #286

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Add prerender property to site #286

merged 2 commits into from
Jan 20, 2021

Conversation

cstaud
Copy link
Contributor

@cstaud cstaud commented Jan 15, 2021

Solves #279

@cstaud cstaud requested review from a team as code owners January 15, 2021 09:31
@netlify
Copy link

netlify bot commented Jan 15, 2021 •
edited
Loading

✔️ Deploy preview for open-api ready!

🔨 Explore the source changes: 7f14cd3

🔍 Inspect the deploy logs: https://app.netlify.com/sites/open-api/deploys/600160fba41b070008484d0f

😎 Browse the preview: https://deploy-preview-286--open-api.netlify.app

FawazFarid
FawazFarid approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@FawazFarid FawazFarid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

rstavchansky
rstavchansky approved these changes Jan 15, 2021
View reviewed changes
Copy link

@rstavchansky rstavchansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always feel silly reviewing the docs for these very minimal API docs, but I see the new property in the output. 👍🏻

@rstavchansky
Copy link

Looks like you're missing a label

@kitop kitop added the type: chore work needed to keep the product and development running smoothly label Jan 15, 2021
@cstaud
Copy link
Contributor Author

cstaud commented Jan 18, 2021

so maybe someone with write access could merge this?

@cstaud
Copy link
Contributor Author

cstaud commented Jan 18, 2021

triggering a release would be also nice afterwards ;-)

@cstaud
Copy link
Contributor Author

cstaud commented Jan 20, 2021

@FawazFarid @rstavchansky can we go on here?

@FawazFarid FawazFarid merged commit 6d8e977 into netlify:master Jan 20, 2021
@FawazFarid
Copy link
Contributor

On it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstavchansky rstavchansky rstavchansky approved these changes

@FawazFarid FawazFarid FawazFarid approved these changes

Assignees
No one assigned
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cstaud @rstavchansky @FawazFarid @kitop