Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration to welldone-wallet #2970

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yoon-Suji
Copy link

  • Add WELLDONE Wallet to near migration option
  • You can batch-import your accounts to our WELLDONE Wallet in our docs page.

@netlify
Copy link

netlify bot commented Nov 9, 2022

👷 Deploy request for near-wallet-staging pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e930953

@netlify
Copy link

netlify bot commented Nov 9, 2022

👷 Deploy request for glittering-pavlova-0e9247 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e930953

@hcho112
Copy link
Contributor

hcho112 commented Nov 10, 2022

Thank you for submitting PR @Yoon-Suji /WELLDONESTUDIO

I have ran the code locally with chrome incognito mode. My first impression is that landing page is amazing/new user friendly in a sense that it captures if user doesn't have welldone studio wallet installed on chrome extension, it guides users nicely. 👍
After I have installed them (also make it available on incognito), I have faced these issues:

  1. Ambiguity after clicking Connect Wallet button.
    After clicking the button, it opens a popup window as below:

image

At this point it's not so clear that if I need to click `create wallet` button or `import wallet` button. Because I was migrating from near-wallet, user may think that they are `importing wallet` so they could click import button instead. (But I believe it is not what it is intended?)

image

So after I have clicked import wallet button and realise it is not the right place, I was easily able to go back and clicked create new wallet flow. After I have insert everything, it froze and nothing was happening after. I was trying to investigate what's going on but all I can see from inspector of the popup was:

image

So overall, these issues need to be fixed.

@Yoon-Suji
Copy link
Author

Hi @hcho112 , thanks for your review!

We found the cause of the problem in the wallet. We will deploy a new version of the wallet today after fixing that issue. You can test tomorrow with new version of wallet(It takes some time for Chrome Webstore to be updated).

Also, thank you for your kind UI feedback. We will add a more detailed guide about ambiguous naming(Import Wallet) to the page!

name: 'WELLDONE Wallet',
icon: <img src={ImgWelldoneWallet} alt="WELLDONE Wallet Logo" />,
getUrl: ({ hash }) => `https://docs.welldonestudio.io/contribution/202211-batch-import#${hash}`,
checkAvailability: () => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last request, is it possible to add ledgerSupport: false, after line 88?
This is new boolean we introduced, to indicate ledger compatibility

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I added it! please check it.

Copy link
Contributor

@hcho112 hcho112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants