-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migration to welldone-wallet #2970
base: master
Are you sure you want to change the base?
feat: migration to welldone-wallet #2970
Conversation
Yoon-Suji
commented
Nov 9, 2022
- Add WELLDONE Wallet to near migration option
- You can batch-import your accounts to our WELLDONE Wallet in our docs page.
👷 Deploy request for near-wallet-staging pending review.Visit the deploys page to approve it
|
👷 Deploy request for glittering-pavlova-0e9247 pending review.Visit the deploys page to approve it
|
Thank you for submitting PR @Yoon-Suji /WELLDONESTUDIO I have ran the code locally with chrome incognito mode. My first impression is that landing page is amazing/new user friendly in a sense that it captures if user doesn't have welldone studio wallet installed on chrome extension, it guides users nicely. 👍
So overall, these issues need to be fixed. |
Hi @hcho112 , thanks for your review! We found the cause of the problem in the wallet. We will deploy a new version of the wallet today after fixing that issue. You can test tomorrow with new version of wallet(It takes some time for Chrome Webstore to be updated). Also, thank you for your kind UI feedback. We will add a more detailed guide about ambiguous naming( |
…into welldone-wallet/add-wallet-option
name: 'WELLDONE Wallet', | ||
icon: <img src={ImgWelldoneWallet} alt="WELLDONE Wallet Logo" />, | ||
getUrl: ({ hash }) => `https://docs.welldonestudio.io/contribution/202211-batch-import#${hash}`, | ||
checkAvailability: () => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last request, is it possible to add ledgerSupport: false,
after line 88?
This is new boolean we introduced, to indicate ledger compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I added it! please check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!