Testing / enhancing oauth integration #336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SSO is fragile and/or not working. We would like to harden this a bit and add some level of support for logging in with CILogon.
Fixes #254
Approach
_oauth2_proxy
cookie / session data and use it to ensure that an account is created for the user in Workbench, then issue a JWT for the user_oauth2_proxy
cookie to the new endpoint mentioned above if the user reaches a protected part of the dashboard without a valid JWTOther minor changes include:
apiserver
andgui
Docker image buildsng-base
Docker image fromxenial
->focal
(Ubuntu 20.04 LTS) andcarbon
->erbium
(NodeJS 12 LTS)apiserver
container log spametcd
to finish its own container startup before continuingapiserver
startupHow to Test
See nds-org/workbench-helm-chart#24 for test steps