Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Postgres 16 #1739

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Upgrade to Postgres 16 #1739

wants to merge 4 commits into from

Conversation

jamesbiggs
Copy link
Collaborator

@jamesbiggs jamesbiggs commented Oct 31, 2024

Ticket URL: EDEV-127

About these changes

Upgrade our local environment and Platform.sh to Postgres 16

How to check these changes

Re-build your local environment, and check out the postgres-upgrade environment on Platform.sh

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

Copy link
Collaborator

@TNA-Allan TNA-Allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jamesbiggs
Regarding issue with fab pull-staging-data causing to prompt for password twice, it is in the dropdb, createdb commands.
I've suggested some changes in the docker-compose.yml and .env for local only which bypasses the prompts - it worked for me.

Comment on lines +9 to +10
environment:
- POSTGRES_PASSWORD=postgres
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make fab pull-staging-data work:

Suggested change
environment:
- POSTGRES_PASSWORD=postgres
env_file:
- .env
environment:
- POSTGRES_PASSWORD=postgres

Add POSTGRES_HOST_AUTH_METHOD=trust to .env, but not on the hosted environment

Comment on lines +44 to +45
- POSTGRES_PASSWORD=postgres
- DATABASE_PASSWORD=postgres
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make fab pull-staging-data work

Suggested change
- POSTGRES_PASSWORD=postgres
- DATABASE_PASSWORD=postgres

Comment on lines +88 to +89
- POSTGRES_PASSWORD=postgres
- DATABASE_PASSWORD=postgres
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make fab pull-staging-data work

Suggested change
- POSTGRES_PASSWORD=postgres
- DATABASE_PASSWORD=postgres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants