-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDEV-106: Feature/delivery options - DO NOT MERGE #1710
Open
Firdaussi
wants to merge
16
commits into
develop
Choose a base branch
from
feature/delivery-options
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,573
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial save
Corrected typo in json file
I will sort out the linting when I return from holiday (2nd September) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delivery Option Availability Conditions.docx
https://national-archives.atlassian.net/issues/EDEV-106
About these changes
Delivery Options are the options visible to the end user for viewing a document. They vary depending on the status of the document and the role of the user. The user has no control over the DO's.
How to check these changes
The best way to test these changes is to look at the details page for any given record. The delivery options appear in a bright yellow panel near the bottom. There are over 30 variations on the messages that can be portrayed and not all information is yet available to Etna, so some of the DO's have Jira ticket placeholder numbers for further work to be done at some point in the future.
Also, if there is an issue with the remote API, you will get a message saying that the Delivery Options are currently unavailable.
To access the remote API you will either need to be on site or using OpenVPN (see attached document). The API is only available during office hours.
OpenVPN setup.docx
css styling is another thing that needs doing and will be done under EDEV-119
Before assigning to reviewer, please make sure you have
Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md