Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCL-380] Version 1 and searchbox homepage #1578

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Donna-H
Copy link
Member

@Donna-H Donna-H commented Oct 29, 2024

Changes in this PR:

Implement V1 (topline nav), search box and browse updates as new homepage

Jira

FCL-380

Next steps

  • Remove homepage variant Waffle tags from the service

Screenshots of UI changes:

Before

before

After

after4

after-static

after-judgment

Copy link
Collaborator

@jacksonj04 jacksonj04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about the number of entirely cosmetic CSS changes here; is stylelint running (or not running) in some weird way?

cc @jlhdxw

Copy link
Contributor

@Terry-Price Terry-Price left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely from a visual point of view it looks good @Donna-H

@jacksonj04 jacksonj04 changed the title Version 1 and searchbox homepage [FCL-380] Version 1 and searchbox homepage Oct 30, 2024
Copy link
Collaborator

@jacksonj04 jacksonj04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few bits in the code itself which need tidying up - we should be removing anything in these templates which relies on Waffle (ie the {% flag %} tags), as well as renaming anything which relies on variant-* in CSS or variables.

We should also remove the Waffle stuff in context_processors.py, the entire waffle_flags function can be deleted here, along with checking that references to waffle_flags in template contexts are removed, and removing judgments.context_processors.waffle_flags from the context processors in base.py.

I've added a checkbox to the PR to remind us to remove the flags themselves from the config when this is done; you might want to remove them locally first to check what happens in your dev environment when they're missing.

@Donna-H Donna-H force-pushed the version-1-and-searchbox-homepage branch from 13664b0 to 6733c61 Compare October 31, 2024 16:57
@@ -14,5 +14,6 @@ module.exports = {
"scss/operator-no-newline-after": null,
"scss/double-slash-comment-whitespace-inside": null,
"scss/dollar-variable-pattern": null,
"declaration-block-single-line-max-declarations": null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we rebase this after merging in the tidying of unnecessary compiled assets then we shouldn't need this line, since it was only relevant for the compiled CSS.

@dragon-dxw dragon-dxw force-pushed the version-1-and-searchbox-homepage branch from 7102129 to 566d8ae Compare October 31, 2024 18:08
@dragon-dxw dragon-dxw force-pushed the version-1-and-searchbox-homepage branch from 566d8ae to 289f34e Compare November 1, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants