Merge pull request #1589 from nationalarchives/fix-hide-linting-issues

Fix hide linting issues
nationalarchives · Oct 31, 2024 · 0a916f7 · 0a916f7
2 parents e0f7a84 + 0b835a4
commit 0a916f7
Show file tree

Hide file tree

Showing 57 changed files with 1,312 additions and 860 deletions.
diff --git a/ds_judgements_public_ui/sass/document_pdf.scss b/ds_judgements_public_ui/sass/document_pdf.scss
@@ -8,8 +8,9 @@ html {
 
 .judgment {
   max-width: 100%;
+
+  font-family: Times, "Times New Roman", "Noto Serif", serif;
   font-size: 1rem;
   line-height: 1.7;
-  font-family: "Times", "Times New Roman", "Noto Serif", serif;
   text-underline-offset: 0.5em;
 }
diff --git a/ds_judgements_public_ui/sass/includes/_basic_search_form.scss b/ds_judgements_public_ui/sass/includes/_basic_search_form.scss
@@ -3,33 +3,40 @@
 
   &__container {
     @include container;
-    text-align: center;
+
     padding: $space-8;
+    text-align: center;
   }
 
   &__container-beta {
     @include container;
-    text-align: center;
+
     padding: 0;
+    text-align: center;
+
     @media (max-width: $grid-breakpoint-medium) {
       padding: $space-3;
     }
+
     @media (max-width: $grid-breakpoint-large) {
       padding: $space-3;
     }
+
     @media (max-width: $grid-breakpoint-extra-large) {
       padding: $space-3;
     }
   }
 
   &__header {
-    font-size: $typography-md-text-size;
-    line-height: 2.8rem;
     display: inline-block;
+
+    margin: 0 $space-6;
+
     font-family: $font-roboto;
+    font-size: $typography-md-text-size;
     font-weight: $typography-normal-font-weight;
+    line-height: 2.8rem;
     color: $color-almost-black;
-    margin: 0 $space-6;
 
     &--sr-only {
       @include sr-only;
@@ -40,25 +47,29 @@
     margin-top: $space-2;
 
     a {
-      color: $color-black;
-      text-decoration: none;
-      border: 0;
-      font-size: $typography-md-text-size;
       position: relative;
-      padding: 0 0 $space-2;
-      border-bottom: 0.125rem solid $color-black;
+
       display: inline-block;
-      background: transparent;
+
+      padding: 0 0 $space-2;
+
       font-family: $font-roboto;
+      font-size: $typography-md-text-size;
       font-weight: $typography-bold-font-weight;
+      color: $color-black;
+      text-decoration: none;
+
+      background: transparent;
+      border: 0;
+      border-bottom: 0.125rem solid $color-black;
 
       &:visited {
         color: $color-black;
       }
 
       &:hover {
-        text-decoration: underline;
         color: $color-black;
+        text-decoration: underline;
       }
     }
   }
@@ -67,27 +78,32 @@
     line-height: $typography-sm-line-height;
 
     a {
-      color: $color-dark-blue;
-      text-decoration: none;
-      border: 0;
-      font-size: $typography-md-text-size;
       position: relative;
-      border-bottom: 1px solid $color-dark-blue;
+
       display: inline-block;
-      background: transparent;
+
+      margin-bottom: $space-3;
+
       font-family: $font-roboto;
+      font-size: $typography-md-text-size;
       font-weight: bold;
-      margin-bottom: $space-3;
+      color: $color-dark-blue;
+      text-decoration: none;
+
+      background: transparent;
+      border: 0;
+      border-bottom: 1px solid $color-dark-blue;
 
       &:visited {
         color: $color-dark-blue;
       }
 
       &:hover {
-        text-decoration: underline;
         color: $color-black;
+        text-decoration: underline;
       }
     }
+
     @media (max-width: $grid-breakpoint-medium) {
       margin-top: 0.125rem;
       text-align: center;
@@ -111,17 +127,14 @@
   width: 100%;
   margin: 0 auto;
 
-  @media (max-width: $grid-breakpoint-medium) {
-    flex-direction: column;
-    width: 100%;
-  }
-
   input[type="submit"] {
     @include call-to-action-button;
-    // The 1px is the border offset of the input this is next to
-    padding: calc($space-3 + 1px) $space-12;
+
     margin-top: $space-2;
     margin-bottom: $space-8;
+
+    // The 1px is the border offset of the input this is next to
+    padding: calc($space-3 + 1px) $space-12;
     border: 2px solid transparent;
 
     .structured-search__container & {
@@ -143,17 +156,19 @@
 
   &__search-term-input {
     @include text_field;
+
+    box-sizing: border-box;
     width: 100% !important;
     min-height: $space-12;
-    font-size: $typography-md-text-size;
     margin-bottom: 0;
-    box-sizing: border-box;
+
+    font-size: $typography-md-text-size;
   }
 
   &__help-text {
-    text-align: left;
     margin: $space-2 $space-4 0 $space-4;
     font-size: $typography-sm-text-size;
+    text-align: left;
 
     @media (min-width: $grid-breakpoint-medium) {
       margin: $space-1 0 $space-2 0;
@@ -163,27 +178,35 @@
   &__header-beta {
     display: flex;
     flex-direction: column;
-    text-align: left;
     margin-left: 12.5rem;
+    text-align: left;
+
     @media (max-width: $grid-breakpoint-medium) {
       display: block;
-      text-align: center;
       margin: 0;
+      text-align: center;
     }
+
     @media (max-width: $grid-breakpoint-large) {
       display: block;
-      text-align: center;
       margin: 0;
+      text-align: center;
     }
+
     @media (max-width: $grid-breakpoint-extra-large) {
       display: block;
-      text-align: center;
       margin: 0;
+      text-align: center;
     }
   }
 
   &__main-label {
-    text-align: left;
     margin: $space-1 0 $space-2 0;
+    text-align: left;
+  }
+
+  @media (max-width: $grid-breakpoint-medium) {
+    flex-direction: column;
+    width: 100%;
   }
 }
diff --git a/ds_judgements_public_ui/sass/includes/_breadcrumbs.scss b/ds_judgements_public_ui/sass/includes/_breadcrumbs.scss
@@ -10,42 +10,49 @@
   }
 
   ol {
-    list-style-type: none;
+    display: inline-block;
+
+    margin: 0;
     padding: 0;
+
     font-family: $font-roboto;
-    display: inline-block;
     font-size: $typography-sm-text-size;
-    margin: 0;
+    list-style-type: none;
 
     li {
-      padding: 0;
-      display: inline-block;
       position: relative;
-      margin-right: $space-2;
-      color: $color-white;
+
+      display: inline-block;
       break-inside: avoid;
+
+      margin-right: $space-2;
+      padding: 0;
+
       line-height: 1.3rem;
+      color: $color-white;
       letter-spacing: 0.3px;
 
       &:not(:nth-child(1)) {
         padding-left: $space-4;
 
         &::before {
           content: "";
-          display: inline-block;
+
           position: absolute;
           top: 0;
           bottom: 0;
           left: -3.31px;
+          transform: rotate(45deg);
+
+          display: inline-block;
+
           width: 7px;
           height: 7px;
           margin: auto 0;
-          -webkit-transform: rotate(45deg);
-          -ms-transform: rotate(45deg);
-          transform: rotate(45deg);
+
           border: solid;
-          border-width: 0.125rem 0.125rem 0 0;
           border-color: $color-white;
+          border-width: 0.125rem 0.125rem 0 0;
         }
       }
     }
@@ -55,11 +62,17 @@
     }
   }
 
+  &__prefix {
+    margin-right: $space-2;
+    color: $color-white;
+  }
+
   @media only screen and (max-width: $grid-breakpoint-medium) {
     ol,
     li {
       display: block;
     }
+
     li {
       &:not(:nth-child(1)) {
         &::before {
@@ -68,9 +81,4 @@
       }
     }
   }
-
-  &__prefix {
-    color: $color-white;
-    margin-right: $space-2;
-  }
 }
diff --git a/ds_judgements_public_ui/sass/includes/_browse_by_court.scss b/ds_judgements_public_ui/sass/includes/_browse_by_court.scss
@@ -1,20 +1,21 @@
 .judgment-browse-by-court {
   &__container {
     @include container;
+
     padding: 0 0 $space-16;
   }
 
   &__header {
+    margin: 0 0 $space-12;
     font-family: $font-roboto;
-    font-weight: $typography-normal-font-weight;
     font-size: $typography-xl-text-size;
-    margin: 0 0 $space-12;
+    font-weight: $typography-normal-font-weight;
   }
 
   &__list {
+    margin: 0 0 $space-12;
     padding: 0;
     list-style-type: none;
-    margin: 0 0 $space-12;
 
     @media (min-width: $grid-breakpoint-medium) {
       column-count: 2;
@@ -28,9 +29,9 @@
 
   &__court {
     padding: $space-8 $space-4;
+    font-family: $font-roboto;
     text-align: center;
     background-color: $color-yellow;
-    font-family: $font-roboto;
 
     @media (max-width: $grid-breakpoint-medium) {
       margin-bottom: $space-4;
@@ -39,8 +40,8 @@
 
   &__court-name {
     display: block;
-    font-size: $typography-lg-text-size;
     margin-bottom: $space-1;
+    font-size: $typography-lg-text-size;
   }
 
   &__court-link {