-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(response-cache): support @cacheControl(scope: CacheControlScope) #1884
Conversation
🦋 Changeset detectedLatest commit: 22b0e27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@envelop/response-cache |
5.1.0-alpha-20230619210318-22b0e271 |
npm ↗︎ unpkg ↗︎ |
@envelop/response-cache-redis |
3.1.0-alpha-20230619210318-22b0e271 |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://1aec7069.envelop.pages.dev |
✅ Benchmark Results
|
4a60b31
to
22b0e27
Compare
Description
Adds support for the
scope
argument of the Apollo's@cacheControl
directive.The goal is to make
@cacheControl
behaviour as close as possible from Apollo's one to make schema using it easily working in Yoga.Type of change
Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Waiting for feat(response-cache): support@cacheControl(maxAge: Int)
#1603Further comments
I have also provided a way to use this feature using the configuration object passed to the plugin.
I have only added a
perSchemaCoordinate
way of configuration as I think having both aperType
andperCoordinate
is a bit redundant since coordinate can represent a type instead of a field.