-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bin): don't allocate in server UDP recv path #2202
Open
mxinden
wants to merge
7
commits into
mozilla:main
Choose a base branch
from
mxinden:server-no-alloc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 26, 2024
-
feat(bin): don't allocate in server UDP recv path
Previously the `neqo-bin` server would read a set of datagrams from the socket and allocate them: ``` rust let dgrams: Vec<Datagram> = dgrams.map(|d| d.to_owned()).collect(); ``` This was done out of convenience, as handling `Datagram<&[u8]>`s, each borrowing from `self.recv_buf`, is hard to get right across multiple `&mut self` functions, that is here `self.run`, `self.process` and `self.find_socket`. This commit combines `self.process` and `self.find_socket` and passes a socket index, instead of the read `Datagram`s from `self.run` to `self.process`, thus making the Rust borrow checker happy to handle borrowing `Datagram<&[u8]>`s instead of owning `Datagram`s.
Configuration menu - View commit details
-
Copy full SHA for 12bb957 - Browse repository at this point
Copy the full SHA 12bb957View commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d23aa74 - Browse repository at this point
Copy the full SHA d23aa74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 786c616 - Browse repository at this point
Copy the full SHA 786c616View commit details
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 91c7920 - Browse repository at this point
Copy the full SHA 91c7920View commit details
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1b7ce8f - Browse repository at this point
Copy the full SHA 1b7ce8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa3f81e - Browse repository at this point
Copy the full SHA aa3f81eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c727c63 - Browse repository at this point
Copy the full SHA c727c63View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.