fix: Don't retire zero-length connection IDs #2182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2182 +/- ##
==========================================
- Coverage 95.39% 95.38% -0.01%
==========================================
Files 112 112
Lines 36373 36373
==========================================
- Hits 34697 34694 -3
- Misses 1676 1679 +3 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 9b5ec71. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.038 ns 99.334 ns 99.640 ns]
change: [-0.7238% -0.2269% +0.3052%] (p = 0.42 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [116.96 ns 117.37 ns 117.80 ns]
change: [-1.3189% -0.7962% -0.2748%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [116.35 ns 116.66 ns 117.07 ns]
change: [-0.9016% -0.4888% -0.1127%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.618 ns 97.775 ns 97.954 ns]
change: [-1.7296% -0.6509% +0.5515%] (p = 0.27 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.15 ms 111.21 ms 111.26 ms]
change: [-0.6945% -0.6207% -0.5469%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.625 ms 27.729 ms 28.857 ms]
change: [-3.9929% +1.4545% +7.2250%] (p = 0.60 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.667 ms 36.386 ms 38.156 ms]
change: [-8.2041% -2.2232% +4.4709%] (p = 0.50 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [24.955 ms 25.775 ms 26.612 ms]
change: [-4.1507% +0.0970% +4.4603%] (p = 0.97 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.632 ms 41.619 ms 43.684 ms]
change: [-7.3968% -1.4326% +5.1747%] (p = 0.66 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [116.26 ms 116.70 ms 117.20 ms]
thrpt: [853.25 MiB/s 856.92 MiB/s 860.15 MiB/s]
change:
time: [-15.019% -4.0547% +2.8436%] (p = 0.68 > 0.05)
thrpt: [-2.7650% +4.2260% +17.673%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: 💔 Performance has regressed. time: [318.92 ms 322.94 ms 327.02 ms]
thrpt: [30.579 Kelem/s 30.965 Kelem/s 31.356 Kelem/s]
change:
time: [+1.7463% +3.3982% +5.1187%] (p = 0.00 < 0.05)
thrpt: [-4.8694% -3.2866% -1.7163%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.701 ms 33.867 ms 34.047 ms]
thrpt: [29.371 elem/s 29.528 elem/s 29.673 elem/s]
change:
time: [-1.4490% -0.5513% +0.3081%] (p = 0.22 > 0.05)
thrpt: [-0.3072% +0.5543% +1.4703%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
|
Working on test cases in #2170. Should I merge all the feature fixes there? |
|
Moving the code seems fine to me. |
|
Now part of #2170. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes us pass the
rebind-addrQNS test.