-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: More migration tests and related fixes #2170
Open
larseggert
wants to merge
14
commits into
main
Choose a base branch
from
test-more-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 11, 2024
-
This expands the migration test quite a bit. It now tests alll the way until retirement of the original path, for both port-only (`rebinding_port`) and address-and-port (`rebinding_address_and_port`) changes. `rebinding_address_and_port` is succeeding, but `rebinding_port` is currently failing. That's because we treat it differently for some reason. If we replace `Paths::find_path_with_rebinding` with `Paths::find_path`, i.e., do proper path validation when only the port changes, the test succeeds. Leaving this out in case I'm missing something about the intent of the difference.
Configuration menu - View commit details
-
Copy full SHA for b782d9d - Browse repository at this point
Copy the full SHA b782d9dView commit details
Commits on Oct 14, 2024
-
fix: Replace
find_path_with_rebinding
withfind_path
We need to do a path challenge even if only the remote port changes.
Configuration menu - View commit details
-
Copy full SHA for 63a1e22 - Browse repository at this point
Copy the full SHA 63a1e22View commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e536595 - Browse repository at this point
Copy the full SHA e536595View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be6f96 - Browse repository at this point
Copy the full SHA 3be6f96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46a4205 - Browse repository at this point
Copy the full SHA 46a4205View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d0b55e - Browse repository at this point
Copy the full SHA 3d0b55eView commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb958cd - Browse repository at this point
Copy the full SHA eb958cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac247fa - Browse repository at this point
Copy the full SHA ac247faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88bdc9b - Browse repository at this point
Copy the full SHA 88bdc9bView commit details
Commits on Oct 24, 2024
-
Merge branch 'main' into test-more-migration
Signed-off-by: Lars Eggert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b61524e - Browse repository at this point
Copy the full SHA b61524eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91c0bb4 - Browse repository at this point
Copy the full SHA 91c0bb4View commit details
Commits on Oct 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 976ea0a - Browse repository at this point
Copy the full SHA 976ea0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 406cd12 - Browse repository at this point
Copy the full SHA 406cd12View commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bff2c92 - Browse repository at this point
Copy the full SHA bff2c92View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.