Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More migration tests and related fixes #2170

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Commits on Oct 11, 2024

  1. test: More migration testing

    This expands the migration test quite a bit. It now tests alll the way
    until retirement of the original path, for both port-only
    (`rebinding_port`) and address-and-port (`rebinding_address_and_port`)
    changes.
    
    `rebinding_address_and_port` is succeeding, but `rebinding_port` is
    currently failing. That's because we treat it differently for some
    reason. If we replace `Paths::find_path_with_rebinding` with
    `Paths::find_path`, i.e., do proper path validation when only the port
    changes, the test succeeds.
    
    Leaving this out in case I'm missing something about the intent of the
    difference.
    larseggert committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b782d9d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. fix: Replace find_path_with_rebinding with find_path

    We need to do a path challenge even if only the remote port changes.
    larseggert committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    63a1e22 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    e536595 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3be6f96 View commit details
    Browse the repository at this point in the history
  3. Fixes

    larseggert committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    46a4205 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3d0b55e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. identity

    larseggert committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    eb958cd View commit details
    Browse the repository at this point in the history
  2. More review comments

    larseggert committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ac247fa View commit details
    Browse the repository at this point in the history
  3. Simplify

    larseggert committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    88bdc9b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge branch 'main' into test-more-migration

    Signed-off-by: Lars Eggert <[email protected]>
    larseggert authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b61524e View commit details
    Browse the repository at this point in the history
  2. Fix merge

    larseggert committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    91c0bb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Address review comments

    larseggert committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    976ea0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    406cd12 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    bff2c92 View commit details
    Browse the repository at this point in the history