Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly check validity of a session ID #1390

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Properly check validity of a session ID #1390

wants to merge 1 commit into from

Conversation

highpon
Copy link
Contributor

@highpon highpon commented Dec 3, 2022

Related Issue #1367

Changes

  • check if the session ID is a valid client-initiated stream id.
  • check if the session ID is a valid bidirectional stream id.
  • check if the session ID is a allowed value.

martinthomson
martinthomson requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a test (or tests) that can show how this change corrects a concrete issue?

@larseggert
Copy link
Collaborator

@highpon would you have that test available or should this be closed?

@larseggert larseggert linked an issue Feb 1, 2024 that may be closed by this pull request
Properly check validity of a session ID #1367
Open
@larseggert
Copy link
Collaborator

Making this a draft PR until it becomes reviewable again.

@larseggert larseggert marked this pull request as draft April 15, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson requested changes

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang is a code owner

@larseggert larseggert Awaiting requested review from larseggert larseggert will be requested when the pull request is marked ready for review larseggert is a code owner

@mxinden mxinden Awaiting requested review from mxinden mxinden will be requested when the pull request is marked ready for review mxinden is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properly check validity of a session ID
3 participants
@highpon @larseggert @martinthomson