Bug fix: pass custom delimiter from Table.from_csv to BigQuery load #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If our source table is loaded from CSV with no transformations, the original source file will be directly loaded to GCS, we may need to pass along a custom delimiter to BigQuery.
austinweisgrau
force-pushed
the
bq_csv_fix
branch
from
5222c9c
to
dc54e45
Compare
shaunagm
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced by recent PR #1062
If our source table is loaded from CSV with no transformations, the original source file will be directly loaded to GCS.
We may need to pass along a custom delimiter to BigQuery.
e.g. for this workflow:
The copy job will fail because the delimiter for the file loaded to GCS will be a
\t, but BigQuery().copy() expects a comma by default.This change fixes that to pass along any custom delimiter set on the Table file load to the BigQuery copy job config.