Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3908: mobx/missing-observer rule false positive with forwardRef #3909

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

urugator
Copy link
Collaborator

@urugator urugator commented Jul 24, 2024

Fixes #3908

image

Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: d8d44e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-mobx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@urugator urugator merged commit 638533e into mobxjs:main Jul 24, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
@@ -74,5 +74,6 @@
"hooks": {
"pre-commit": "pretty-quick --staged"
}
}
},
"packageManager": "[email protected]+sha1.1959a18351b811cdeedbd484a8f86c3cc3bbaf72"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this configuration? 🤔

Copy link
Collaborator Author

@urugator urugator Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corepack can't live without it unless you set env variable COREPACK_ENABLE_AUTO_PIN to 0, which is quite inconvinient to do. But now when thinking about it, yarn maybe also checks this field, so it may cause issues to non-corepack users, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, there is a SKIP_YARN_COREPACK_CHECK env var for yarn, but this is equally bad as the need to set COREPACK_ENABLE_AUTO_PIN. Feel free to revert the change if it's causing problems, unless you know of a better solution of course.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint mobx/missing-observer rule false positive with forwardRef
2 participants