Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3885 by adding react-dom / react-native as peerDeps #3906

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix #3885 by adding react-dom / react-native as peerDeps #3906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7d68f5
fix: added react-dom as optional peer dep, fixes #3885
mweststrate Jul 17, 2024
221cfc8
v4.0.7-alpha
mweststrate Jul 17, 2024
65495b0
changeset
mweststrate Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/five-trees-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"mobx-react-lite": patch
---

Added react-dom / react-native as optional dependencies to hint package manager that one of those might be needed. Fixes #3885
10 changes: 6 additions & 4 deletions packages/mobx-react-lite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "mobx-react-lite",
"version": "4.0.7",
"version": "4.0.7-alpha",
"description": "Lightweight React bindings for MobX based on React 16.8+ and Hooks",
"source": "src/index.ts",
"main": "dist/index.js",
Expand Down Expand Up @@ -41,7 +41,9 @@
},
"peerDependencies": {
"mobx": "^6.9.0",
"react": "^16.8.0 || ^17 || ^18"
"react": "^16.8.0 || ^17 || ^18",
"react-dom": ">=16.8.0",
"react-native": ">0.69"
},
"peerDependenciesMeta": {
"react-dom": {
Expand All @@ -52,8 +54,8 @@
}
},
"devDependencies": {
"mobx": "^6.12.2",
"expose-gc": "^1.0.0"
"expose-gc": "^1.0.0",
"mobx": "^6.12.2"
},
"keywords": [
"mobx",
Expand Down