Pass expected institutions during benchmark creation #624
+71
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristizabal95
added
type: enhancement
aristizabal95
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
aristizabal95
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows benchmark owners to optionally specify which sites are expected to participate on a benchmark. This is done through a CSV file that contains two columns:
emailandinstitution. This additiona provides the following benefits:The institutions list are stored as a dictionary in the benchmark object. The CSV file is parsed by the medperf CLI to extract the information in the expected format. This list can only be visible by the benchmark owner.