[WIP] Web UI dataset #617
Open
[WIP] Web UI dataset #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cli/medperf/web_ui/yaml_fetch/routes.py
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Check if user is already authenticated | ||
| if token == security_token: | ||
| # User is already authenticated, redirect to original URL | ||
| return RedirectResponse(url=redirect_url, status_code=status.HTTP_302_FOUND) |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
| redirect_url: str = Form("/"), | ||
| ): | ||
| if token == security_token: | ||
| response = RedirectResponse(url=redirect_url, status_code=status.HTTP_302_FOUND) |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
| ): | ||
| if token == security_token: | ||
| response = RedirectResponse(url=redirect_url, status_code=status.HTTP_302_FOUND) | ||
| response.set_cookie(key=AUTH_COOKIE_NAME, value=token) |
Check warning
Code scanning / CodeQL
Failure to use secure cookies Medium
| ): | ||
| if token == security_token: | ||
| response = RedirectResponse(url=redirect_url, status_code=status.HTTP_302_FOUND) | ||
| response.set_cookie(key=AUTH_COOKIE_NAME, value=token) |
Check warning
Code scanning / CodeQL
Construction of a cookie using user-supplied input Medium
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #606
Adds functionality for creating & managing datasets
Dataset submission
p1list benchmarks as cards with detailed info (as on "benchmarks list" page), + highlight chosen onep3allow to choose dataprep mlcube insteadp2check length beforehand? DS submission would fail if description is > 20 characters ?p2check length beforehand?p3"Submit as prepared" flagp1check how errors are displayed & handledp2metadata path (what is it?) (is required if dataset is already prepared)p2redesign path picking panelp2"go back" button / navigationp1check how errors are displayed & handledSubmitted dataset displaying (dataset details page)
p2display paths (data path, labels path)p1display dataset statisticsDataset preparation
p1clean log messages from magic bytesp1distinguish messages to headers + usual lines in the medperf codep1display header messages properlyp1display log messages without jsonp2log lines highlighting?p1spinner at text headers to underline process is runningp1check how errors are displayed & handledp1button "back to the dataset" renamep1check how errors are displayed & handled (display exceptions in the log)Prepared dataset displaying (dataset details page)
p2if report exists, "Allowed automatic report submission" flagp2if report exists, link / path to the reportp1if dataset is prepared, unlock next button "set operational" (locked if not prepared)Set operational
p0"Set operational" button on dataset detail pagep0Set operationalp0Disable button if already operationalp1check how errors are displayed & handledAssociate
p1"Associate with the benchmark" button on the dataset detail page (no choice of benchmarks)p3choice of benchmarks if dataset was created with dataprep mlcubep1associatep1check how errors are displayed & handledRun benchmark
p1"Run benchmark" button on the dataset detail pagep1running benchmark page with logsp1check how errors are displayed & handledp2"Run all" buttonp2add "Running" status in addition to "Pending"p1make all status (Run/Failed/Pending/Done) buttons as separate objectsp1modify default (right-after-load) button to "Waiting for status.."p2adjust logs panel height if there is no logsSubmit result
p1"Submit result" button on the dataset detail pagep1Submit resultp1check how errors are displayed & handledp2"Submit all" buttongeneral dataset UI
p2design buttons prepare-operational-... navigation to one line?p1hide buttons panel if you're not the dataset owner?p3redesign state displaying (we'd have dev/op floating blocks in the header + set-op button in the footer)Technical refactoring
p1split routes to different files:dataset/submission.py,dataset/preparation.py