-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package without editable flag #576
base: main
Are you sure you want to change the base?
Conversation
…nstalled not from git in the future
# Conflicts: # cli/medperf/utils.py # cli/requirements.txt # server/setup-dev-server.sh
# Conflicts: # cli/medperf/cli.py # cli/medperf/utils.py # cli/requirements.txt
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
49dc914
to
872cc66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VukW looks good, although I believe there is no need to move around tokens and certs since we decided that developers will anyway clone the repo and install it from source, so the added complexity of moving mock tokens file and having a ~ medperf dev folder could be really omitted; nothing is gained I guess?
anyway please feel free to merge or edit
@VukW ah I guess the auth test needs to have |
Looked one more time to it. local tokensLocal tokens path is hardcoded in
IMO it's better to do (2) or (3), as (1) looks more error-prone Local certIt's already defined in
To tell truth I'm confused and not sure which solution I'd prefer as all of them seem to have some issues. But, maybe, it's easier to me to agree with cluttering home folder rather then fix config fields manually after any config reset (??? tho I believe it would not be really often). Need your opinion, man @hasan7n :) |
An ancestor of #550 (branch was renamed)
The goal is to make medperf client installable from pypi. This PR is the first part that allows installing package not from repository
A few changes were implemented:
cert.crt
,cert.key
andmock_tokens/tokens.json
to~/.medperf_config/.local_server/
so detached medperf client can use it. NB: this change breaks the behavior for existing developers (as path to local server cert is already defined in user config). You should update local config'scertificate
path to~/.medperf_config/.local_server/cert.crt
.pip install -e ./cli
replaced withpip install ./cli
everywhere