Fix parent-child relationship issue in text2chakra_converter.py #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There was an
AttributeError
when attempting to add a parent node to a child node intext2chakra_converter.py
. The issue occurred because theNode
message inet_def.proto
does not have aparent
field.Solution:
The fix involves using the existing
ctrl_deps
field to maintain parent-child relationships. Specifically, I modified theadd_parent
function to append the parent node's ID to thectrl_deps
field of the child node.