Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inform submission about evaluation step #720

Closed
wants to merge 3 commits into from
Closed

Inform submission about evaluation step #720

wants to merge 3 commits into from

Conversation

Niccolo-Ajroldi
Copy link
Contributor

@Niccolo-Ajroldi Niccolo-Ajroldi commented Mar 25, 2024 •
edited
Loading

Inform the submission if an evaluation is going to happen at the current step or not.

See related issue: #719

Modifications:

  • moved evaluation decision before update_params
  • added is_eval_step argument to update_params
  • modified all submissions to include is_eval_step

@Niccolo-Ajroldi Niccolo-Ajroldi requested a review from a team as a code owner March 25, 2024 16:46
@github-actions GitHub Actions
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the base branch from main to dev March 25, 2024 21:27
@fsschneider
Copy link
Contributor

I think we can close this PR judging from the WG meeting summarized in #719 (especially #719 (comment)).

@fsschneider fsschneider closed this Apr 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Niccolo-Ajroldi @fsschneider