Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CueStyler: Fix TimedTextPadding being applied incorrectly #9248

Open
wants to merge 1 commit into
base: winui3/release/1.5-stable
Choose a base branch
from

Conversation

softworkz
Copy link

Compare with TimedTextDisplayAlignment and TimedTextLineAlignment

TimedTextDisplayAlignment.Before means Top
TimedTextDisplayAlignment.After means Bottom
TimedTextLineAlignment.Start means Left
TimedTextLineAlignment.End means Right

Compare with TimedTextDisplayAlignment and TimedTextLineAlignment

TimedTextDisplayAlignment.Before means Top
TimedTextDisplayAlignment.After means Bottom
TimedTextLineAlignment.Start means Left
TimedTextLineAlignment.End means Right
@softworkz
Copy link
Author

@bpulliam - What does the removal of the "needs-triage" label mean? What is the outcome of your triage?

@codendone
Copy link
Contributor

Removing "needs-triage" means we've internally assigned the issue. The current area owner for CueStyler has been asked to review this PR and handle it appropriately. (I'm assuming your change is correct, but the area owner needs to review, test, and carry the change in if that is the case.) There has been some delay here as we're waiting on availability of the area owner. Thanks for your patience.

@softworkz
Copy link
Author

Thanks Mike, for the update and clarification, much appreciated!

@softworkz
Copy link
Author

A secondary question would be whether the patch can be applied to the WinUI2 tree as well?
Due to the messed-up strategy we were forced to create two variants of our app: WinUI3 for Desktop and UWP for Xbox, since UWP is the only way to deliver our app to Xbox.
Both variants have been pushed to the store as flighted submission to the Microsoft Store this week and of course, both are suffering from the same issues (this PR, the other PR: #9224, and this issue: #9126).
Our software is known by Millions and if there are any TAP or other programs exist for Xbox app technologies where our company could participate, please advise or contact me privately at hotmail.com.
Thanks

@codendone
Copy link
Contributor

As stated in here, the general policy for WinUI2 bugs is to close them so we can focus on WinUI3. WinUI2 changes add significant extra work, particularly in areas like this change where it requires changes in Windows across multiple releases.

However, there can be exceptions, particularly in areas where no workaround is available. This will need discussion once these PRs are fully understood and handled for WinUI3.

@softworkz
Copy link
Author

softworkz commented Mar 13, 2024

As stated in here, the general policy for WinUI2 bugs is to close them so we can focus on WinUI3.

Yes, I understand and have read this (multiple times).

add significant extra work,

My request was based on the assumption that CueStyler.cpp is largely identical between WinUI2 and WinUI3, in which case it would be straightforward.

it requires changes in Windows across multiple releases.
However, there can be exceptions, particularly in areas where no workaround is available. This will need discussion once these PRs are fully understood and handled for WinUI3.

The particular area would be Xbox only (so no multiple Windows releases), where no WinUI3 is available.

Of course you'll need to weigh these things for making a decision. Maybe it helps that it's a bundle of several issues, all about CueStyler (this PR, the other PR #9224 , #7981 and #9126). :-)

@DmitriyKomin DmitriyKomin self-assigned this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants