Fix dropped events #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the CLA carefully before submitting your contribution to Mercari.
Under any circumstances, by submitting your contribution, you are deemed to accept and agree to be bound by the terms and conditions of the CLA.
https://www.mercari.com/cla/
WHAT
Updates to
Servicesare sometimes dropped when a cluster has many services.By removing the BucketRateLimiter attached to the workqueue, this PR fixes this problem.
WHY
The
DefaultControllerRateLimiter()contains aBucketRateLimiter(implementation of a token bucket) with the parameters 10 tokens per second and bucket size of 100.The Informer listens to all addition/deletion/updates made to
Services, which saturates this token bucket. This rate limit is unnecessary, and removing it fixes the problem.Please merge after #8, since fix-dropped-events branch contains commits from #8