[core] Added ComponentType::RemoteID

[dakejahl]

• Removed unused duplicate enum class in system.h Can we consolidate System::ComponentType with Mavsdk::ComponentType?
• Added ComponentType::RemoteID -- I'm transitioning RemoteIDTransmitter to MAVSDK
• Removed ComponentType::Custom to reduce confusion since it was defaulting to MAV_TYPE_GENERIC
• Added Mavsdk::Configuration constructor for ComponentType::RemoteId

[dakejahl]

Nevermind it looks like it didn't do a clean build and ComponentType in System is indeed used. But now I'm confused why there are 2 definitions in different namespaces that are not in the same order. Can we just use the Mavsdk::ComponentType?

[dakejahl]

This is hard to do without introducing circular dependencies. Can we have some kind of global_include.hpp where we can define things common to the core classes?

[julianoes]

Thanks for this.

I absolutely don't want a global_include.h file, however, I also don't want circular dependencies, so we'll have to clean it up.

I also don't want multiple component enums. I thought I had already cleaned that up but it looks like I haven't, so I should do that.

[julianoes]

#2416

[dakejahl]

Rebased off of your branch

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[julianoes]

Thanks for cleaning my changes up and adding yours :)