Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sssom api should use prefixes from mapping sets first, and obocontext second #85

Open
matentzn opened this issue Dec 1, 2023 · 2 comments

Comments

@matentzn
Copy link
Collaborator

matentzn commented Dec 1, 2023

SSSOM will have a wild variety of all prefixes, some of which are in the obo context, others of which are not.

What is ok is to try and standardise the prefixes mapping sets pre-ingest using curies.standardize() command, but we always have to prefer the built-in curie maps over the obo_context when interpreting the mappings.

@anitacaron I know we talked about this dependency at some point, which may have been ok for a first prototype, but not for the full fledged API; the point of sssom mapping sets is that they spring their own mapping sets.

Can you share the part of the code that would need to be changed to get rid of the obo context dependency?

@anitacaron
Copy link
Collaborator

mapping sets first, and obocontext second

This is exactly what I'm doing. The problem is when they have different definitions for the same prefix.

@matentzn
Copy link
Collaborator Author

Maybe we need to think a bit more in this direction: https://curies.readthedocs.io/en/latest/reconciliation.html

I think you should be able to chain conflicting maps and curies somehow pics them in some order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants