-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix for mesh
not conform to OBO context
#46
Comments
The prefix does not have to conform to obo context if it is included in the mappings. No curie_map in there? |
If this is a result of my latest PR: In
So |
SSSOM-API only depends on the OBO Context. |
I'm a little confused. The prefix |
Sorry, I'm referring to the previous mappings available here mondo.sssom.tsv, mesh_chebi_biomappings.sssom.tsv and gene_mappings.sssom.tsv. Now I checked the registry, and there are two others added yesterday. |
Yes, those were added by me via #44 |
Yes, these new mappings are good. One more reason to update the others. I updated the issue to be more specific. |
I moved this discussion here for now: mapping-commons/sssom-api#85 @anitacaron we can attack this from two sides, but it must be from both:
@glass-ships can you make sure that all curies you output in gene mappings and chebi mesh are standardised uses |
sure, I can try. |
The prefix should be
mesh
instead ofMESH
formondo.sssom.tsv
andmesh_chebi_biomappings.sssom.tsv
. For reference, OBO Context at Bioregistry.SSSOM-API can't expand or compress properly when it retrieves the' mesh' mappings, resulting in None.
Related to #29
The text was updated successfully, but these errors were encountered: