Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix for mesh not conform to OBO context #46

Closed
anitacaron opened this issue Dec 1, 2023 · 9 comments · Fixed by #47
Closed

Prefix for mesh not conform to OBO context #46

anitacaron opened this issue Dec 1, 2023 · 9 comments · Fixed by #47
Assignees

Comments

@anitacaron
Copy link
Contributor

anitacaron commented Dec 1, 2023

The prefix should be mesh instead of MESH for mondo.sssom.tsv and mesh_chebi_biomappings.sssom.tsv. For reference, OBO Context at Bioregistry.

SSSOM-API can't expand or compress properly when it retrieves the' mesh' mappings, resulting in None.

Screenshot 2023-12-01 at 16 27 41

Related to #29

@matentzn
Copy link
Member

matentzn commented Dec 1, 2023

The prefix does not have to conform to obo context if it is included in the mappings. No curie_map in there?

@hrshdhgd
Copy link
Member

hrshdhgd commented Dec 1, 2023

If this is a result of my latest PR:

In umls-ingest: The priority sequence for the curies=> Converter for now is:

  1. OBO converter
  2. Bioregistry Converter
  3. SSSOM default converter.

So mesh is the prefix in the curie_map: See here

@anitacaron
Copy link
Contributor Author

SSSOM-API only depends on the OBO Context.

@hrshdhgd
Copy link
Member

hrshdhgd commented Dec 1, 2023

I'm a little confused. The prefix mesh is as expected (as per your first statement). @matentzn why am I tagged here?

@anitacaron
Copy link
Contributor Author

Sorry, I'm referring to the previous mappings available here mondo.sssom.tsv, mesh_chebi_biomappings.sssom.tsv and gene_mappings.sssom.tsv. Now I checked the registry, and there are two others added yesterday.

@hrshdhgd
Copy link
Member

hrshdhgd commented Dec 1, 2023

Yes, those were added by me via #44

@anitacaron
Copy link
Contributor Author

Yes, these new mappings are good. One more reason to update the others. I updated the issue to be more specific.

@anitacaron anitacaron assigned matentzn and unassigned hrshdhgd Dec 1, 2023
@matentzn
Copy link
Member

matentzn commented Dec 1, 2023

I moved this discussion here for now: mapping-commons/sssom-api#85

@anitacaron we can attack this from two sides, but it must be from both:

  1. Weaken the assumption of obo context (issue above)
  2. Standardising as much as possible towards it.

@glass-ships can you make sure that all curies you output in gene mappings and chebi mesh are standardised uses curies.Converter.standardize() using the obo_converter()?

@matentzn matentzn assigned glass-ships and unassigned matentzn Dec 1, 2023
@glass-ships
Copy link
Contributor

sure, I can try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants