Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1103 this PR looks to optimise the query when fetching discounts. Beforehand we just loaded all available discounts, regardless of whether they were actually needed and then left it up to the individual types to figure out whether they should apply, this will be quite taxing on sites with large amounts of discounts. This PR looks to change the following:
usable
scope to discounts so we can query based on whetheruses
has exceededmax_uses
if present.products
scope to discounts to query based on whether the discount is limited to certain product ids.Discounts::getDiscounts()
method now accepts a nullableCart
model to be passed.This PR relies on the tweak on #1108