ohm-525 Teacher Audit Log #21

sketchings · 2020-04-01T22:25:26Z

See parent task https://lumenlearning.atlassian.net/browse/OHM-525
DATA MODEL:

Teacher user
course ID
action
item ID
timestamp
metadata: always include source of action (what page is the action initiated)

smith750

This looks like what was discussed yesterday and what the AC describe to me. Thanks @sketchings .

drlippman

Maybe change the "echo" at the end to reflect the correct table name. Otherwise seems to follow what we discussed.

assess2/AssessRecord.php

drlippman · 2020-04-17T17:02:43Z

assess2/AssessRecord.php

@@ -180,6 +183,17 @@ public function saveRecord() {
      }
      $stm = $this->DBH->prepare($query);
      $stm->execute($qarr);
+      if ($stm->rowCount()>0) {
+          $result = TeacherAuditLog::addTracking(


This looks like it's going to record a teacher audit log even every time the assessment record is updated, which can happen without a grade change (like when feedback is added), and will also happen every time a student submits something, which shouldn't go in the teacher audit log.

checking for $this->data['scoreoverride']==true seems to work, and I also am recording score details

With that, it looks like it's still going to record a log entry every time the assessment record is saved, if there is a scoreoverride set. Also, it shouldn't be necessary to decode the scoreddata - it was already decoded, and it doesn't even look like you're using it. The loadRecord call is also redundant - if we're saving the record, it's already loaded, and calling loadRecord again is causing it to next transactions and is triggering an error.

TBH, I'm not 100% convinced this log entry is even useful, since the original grades are still present and visible when looking at the student's attempts, and it's obvious there's a grade override. Logging provides no additional information.

assess2/gbclearattempt.php

drlippman · 2020-04-17T17:10:06Z

assess2/gbclearattempt.php

+            $aid,
+            array('user_grades'=>$grades)
+        );
+    }


It looks like there's only logging for the "delete all attempts" clearing, but not for any of the individual attempt or question version clearing later in the file.

assess2/loadassess.php

course/addassessment.php

course/addassessment2.php

drlippman · 2020-04-17T17:23:47Z

course/addquestionssave.php

+			$cid,
+			"Assessment Settings Change",
+			$aid,
+			$qarr


Add source

It may be more useful to log what was changed, but that would be more difficult of course.

drlippman · 2020-04-17T17:44:08Z

includes/TeacherAuditLog.php

+            return false;
+        }
+        //always include calling file as source to metadata
+        $metadata = ['source'=>basename(debug_backtrace()[0]['file'])]+$metadata;


Will the debug_backtrace source be more useful than the $_SERVER['REQUEST_URI']?

If we're trying to be able to say "this happened when you clicked on something on this page" I'm not sure if the innermost script is what we want to know.

includes/unenroll.php

ohm-527 migration for data model ohm-527 change creation timestamp to created_at field ohm-527 match ENUM plural form ohm-527 update table name output ohm-528 initial logging class and testing pattern ohm-528 add findCourseAction and update/cleanup tests ohm-525 fix in memory sqlite db for tests ohm-525 use global userid ohm-525 add source file to all metadata ohm-525 Assessment setting changes logged ohm-525 update for mass updates not reqiring itemid ohm-525 Mass change assessment ohm-525 Unenroll with grade save ohm-525 Mass Assessment Date Change ohm-525 Clear Attempts, Question Settings Change, Assessment Settings Change ohm-525 Clear Attempts ohm-525 Clear Scores and Attempts ohm-525 update Clear Scores ohm-524 delete items ohm-525 initial Teacher Audit Log Report ohm-525 use blob for metadata ohm-525 update for code bugs ohm-525 record updated scores ohm-525 update Clear Scores, Clear Attempts. Change 'Grade Override' to 'Grade Change' ohm-525 mass change dates ohm-525 Change Grades Old Assessment ohm-525 record new assessment updates ohm-525 update include to TeacherAuditLog ohm-525 build assess2 for production ohm-525 loadRecord to get score data. Only record if this is a scoreoverride ohm-525 do not need to log teacher clearing their own scores ohm-525 clear attempts ohm-525 do not need to record for adding a new assessment ohm-525 clean up logged data ohm-525 record offline, forum and external grades from imas_grades ohm-525 must be admin to access Teacher Audit Log Report ohm-525 update breadcrumbs ohm-525 only pull imas_grades where appropriate ohm-525 count forums ohm-525 fix migrations ohm-525 add to actions file. Allow teacher audit log report to have no information. Add URI to tests ohm-525 add tracking grades. Add methods to report on count

drlippman · 2020-05-12T03:45:58Z

course/addquestions.php

@@ -144,11 +153,31 @@
 			require_once('../includes/filehandler.php');
 			deleteallaidfiles($aid);
 			if ($aver > 1) {
+                $stm = $DBH->query("SELECT userid,score FROM imas_assessment_records WHERE assessmentid=:assessmentid");


This is an invalid query: needs to use prepare with an execute if using a placeholder

drlippman · 2020-05-12T03:46:34Z

course/addquestions.php

 				$stm = $DBH->prepare("DELETE FROM imas_assessment_records WHERE assessmentid=:assessmentid");
 			} else {
-				$stm = $DBH->prepare("DELETE FROM imas_assessment_sessions WHERE assessmentid=:assessmentid");
+                $query = "SELECT userid, bestscores FROM imas_assessment_sessions WHERE assessmentid=$aid";


This should probably be done using prepare and execute, rather than sticking $aid directly into the query.

drlippman · 2020-05-13T05:25:49Z

course/masschgdates.php

 		}
 		if (count($forumbasictoupdate)>0) {
 			$placeholders = Sanitize::generateQueryPlaceholdersGrouped($forumbasictoupdate, 4);
 			$query = "INSERT INTO imas_forums (id,startdate,enddate,avail) VALUES $placeholders ";
 			$query .= "ON DUPLICATE KEY UPDATE startdate=VALUES(startdate),enddate=VALUES(enddate),avail=VALUES(avail)";
 			$stm = $DBH->prepare($query);
 			$stm->execute($forumbasictoupdate);
+			if ($stm->rowCount()>0) {
+				$updated_settings = true;
+				$metadata["Forums Basic"] = $forumbasictoupdate);


syntax error from the )

drlippman · 2020-05-13T05:35:16Z

course/massexception.php

 					}

 				} else if (isset($_POST['forceclear'])) {
+					//get old grades
+					$stm = $DBH->prepare("SELECT userid, bestscores FROM imas_assessment_sessions WHERE userid=? AND assessmentid=$aid");


This and a few lines down have a mix of named placeholders, ? placeholders, and directly injected parameters.

sketchings requested review from drlippman, smith750 and kittysnacks April 1, 2020 22:25

smith750 approved these changes Apr 1, 2020

View reviewed changes

sketchings force-pushed the ohm-525-teacher-audit-log branch from 5301031 to 9d273c8 Compare April 1, 2020 23:18

drlippman approved these changes Apr 2, 2020

View reviewed changes

sketchings changed the title ~~ohm-527 migration for data model~~ ohm-525 Teacher Audit Log Apr 13, 2020

sketchings requested a review from drlippman April 17, 2020 20:32

drlippman reviewed Apr 20, 2020

View reviewed changes

drlippman reviewed Apr 23, 2020

View reviewed changes

includes/unenroll.php Show resolved Hide resolved

sketchings force-pushed the ohm-525-teacher-audit-log branch from b4a0c04 to f1dab79 Compare May 1, 2020 15:35

sketchings force-pushed the ohm-525-teacher-audit-log branch from d9f1c02 to fc0177d Compare May 6, 2020 22:47

ohm-525 remove FROM_UNIXTIME to speed up query

974e989

drlippman reviewed May 12, 2020

View reviewed changes

Alena Holligan added 2 commits May 12, 2020 10:57

ohm-525 update PDO queries

33857ab

ohm-525 update PDO queries

28557aa

drlippman reviewed May 13, 2020

View reviewed changes

Alena Holligan and others added 10 commits May 15, 2020 11:04

ohm-607 logging assessment setting changes

7f6d8fd

ohm-607 logging question settings

0f0a0bc

Cleanup audit log on hard course delete

de5ea26

ohm-607 fix mistype groupid

015592c

ohm-607 compare and record specific changes from mass date changes

0222246

ohm-525 update typing and documentation for class

f32156a

ohm-607 update deleting course items to all use course/delitembyid.php

f748518

ohm-607 update mass exception 'Clear Attempts'

9fae6c8

ohm-607 'Clear Attempts'

cf0c8c6

ohm-607 update to remove errors when no students are enrolled

f97028b

Alena Holligan added 6 commits May 21, 2020 13:56

ohm-607 fix code and what is recorded

9b74a43

ohm-607 grade override

0b8e23f

ohm-607 update deletes and grade execute

e6c94bb

ohm-607 update deletes

0ddbb74

ohm-525 update type requirements for findCourseItemAction

777b045

ohm-525 remove required file

60efdb7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ohm-525 Teacher Audit Log #21

ohm-525 Teacher Audit Log #21

sketchings commented Apr 1, 2020

smith750 left a comment

drlippman left a comment

drlippman Apr 17, 2020

sketchings Apr 23, 2020

drlippman May 13, 2020

drlippman May 13, 2020

drlippman Apr 17, 2020

drlippman Apr 17, 2020

drlippman Apr 17, 2020

drlippman May 12, 2020

drlippman May 12, 2020

drlippman May 13, 2020

drlippman May 13, 2020

ohm-525 Teacher Audit Log #21

Are you sure you want to change the base?

ohm-525 Teacher Audit Log #21

Conversation

sketchings commented Apr 1, 2020

smith750 left a comment

Choose a reason for hiding this comment

drlippman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment