Merge pull request #28 from luisherranz/fix-production-build

Fix production build
luisherranz · Jun 26, 2023 · ff7d151 · ff7d151
2 parents b87f4a5 + cf226ba
commit ff7d151
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/chilled-rivers-march.md b/.changeset/chilled-rivers-march.md
@@ -0,0 +1,5 @@
+---
+"deepsignal": patch
+---
+
+Fix production tests and a couple of problems in production with `peek` and the `ownKeys` trap.
diff --git a/karma.conf.js b/karma.conf.js
@@ -83,7 +83,7 @@ function createEsbuildPlugin() {
 
 			// Aliasing: If "MINIFY" is set to "true" we use the dist/
 			// files instead of those from src/
-			build.onResolve({ filter: /^@preact\/.*/ }, args => {
+			build.onResolve({ filter: /^deepsignal\/.*/ }, args => {
 				const pkg = alias[args.path];
 				return {
 					path: pkg,

diff --git a/packages/deepsignal/core/src/index.ts b/packages/deepsignal/core/src/index.ts
@@ -24,7 +24,9 @@ export const peek = <
 ): RevertDeepSignal<RevertDeepSignalObject<T>[K]> => {
 	peeking = true;
 	const value = obj[key];
-	peeking = false;
+	try {
+		peeking = false;
+	} catch (e) {}
 	return value as RevertDeepSignal<RevertDeepSignalObject<T>[K]>;
 };
 
@@ -115,7 +117,7 @@ const objectHandlers = {
 	},
 	ownKeys(target: object): (string | symbol)[] {
 		if (!objToIterable.has(target)) objToIterable.set(target, signal(0));
-		objToIterable.get(target).value;
+		objToIterable.get(target).value = objToIterable.get(target).value;
 		return Reflect.ownKeys(target);
 	},
 };