Feat: Browser Engine waits for the css selector in Friendly Name wrapped in brackets, if specified #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ped with brackets, if specified
robert-cardillo
force-pushed
the
real-browser-monitor-wait-for-selector
branch
from
bf0c4db
to
ffbd312
Compare
CommanderStorm
requested changes
Oct 23, 2024
There was a problem hiding this comment.
First off all: The PR template is there for a reason, please fill it out.
The name being used like this is reaaaly obvious for users.
A user would have to read this code to figure out why this is happening.
Also using brackets is somewhat common practice in names and not common in specifying a CSS selector (at least as presented)
What would be possible is doing two separate PRs:
- migrating this monitor to be monitor condition based (see the dns monitor)
- add a condition to wait for a selector
CommanderStorm
added
area:monitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.