Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend length of status bars in status page #4376

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

amyyeung17
Copy link
Contributor

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #4365.
Adjusted column values in PublicGroupList to extend status bars in small screens.

Type of change

Please delete any options that are not relevant.

  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Screen Shot 2024-01-16 at 2 27 11 PM

Comments

I wasn't sure if the request was asking to extend for all or just small screens. Based on the screenshot, I assumed the latter.

@CommanderStorm CommanderStorm changed the title Fix #4365 - Extend length of status bars in status page Extend length of status bars in status page Jan 17, 2024
@mobeicanyue

This comment was marked as duplicate.

@Zaid-maker

This comment was marked as resolved.

Copy link
Contributor

@mobeicanyue mobeicanyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this style of bar will be better

image

image

src/components/PublicGroupList.vue Outdated Show resolved Hide resolved
src/components/PublicGroupList.vue Outdated Show resolved Hide resolved
@mobeicanyue mobeicanyue mentioned this pull request Feb 1, 2024
7 tasks
@CommanderStorm CommanderStorm added the area:status-page Everything related to the status page label Feb 12, 2024
@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label May 19, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the style change! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 4b68a86 into louislam:master Aug 24, 2024
6 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Oct 16, 2024
CommanderStorm added a commit that referenced this pull request Oct 16, 2024
@CommanderStorm CommanderStorm removed this from the 2.0.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:status-page Everything related to the status page pr:needs review this PR needs a review by maintainers or other community members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could we extend the length of status bar?
4 participants