Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xilem: Add a way to allow impl WidgetViewSequence as <seq> in flex(<seq>) #558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

xilem: Add a way to allow impl WidgetViewSequence as <seq> in flex(<seq>) #558

wants to merge 1 commit into from
+137 −3

Conversation

Philipp-M
Copy link
Contributor

(I'll add doc-tests/comments before (potentially) merging, tests would probably also be useful, but we don't have such infrastructure yet...)

DJMcNab
DJMcNab reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the energy to reason about this at the moment, but it looks reasonable.

We should add a diagnostic::on_unimplemented on FlexSequence which uses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Philipp-M @DJMcNab