Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require phone number when verify sms code #238

Merged
merged 7 commits into from
May 11, 2024
Merged

Conversation

juvenn
Copy link
Member

@juvenn juvenn commented May 10, 2024

No description provided.

@juvenn
Copy link
Member Author

juvenn commented May 11, 2024

Composer 2.3.0 dropped support for PHP <7.2.5 and you are running 5.6.40-70+ubuntu22.04.1+deb.sury.org+1, please upgrade PHP or use Composer 2.2 LTS via "composer self-update --2.2". Aborting.

https://github.com/leancloud/php-sdk/actions/runs/9041650983/job/24847269660?pr=238

@juvenn
Copy link
Member Author

juvenn commented May 11, 2024

Fatal error: Declaration of ACLTest::setUpBeforeClass() must be compatible with PHPUnit\Framework\TestCase::setUpBeforeClass(): void in /app/test/ACLTest.php on line 10

测试升级 php 8.0 失败,因为 phpunit 8.x 会报上面的错误。而 phpunit 7.x 限制了 php < 8 。只是测试有这个依赖要求,库本身并没有依赖。所以尽管没有测试,在其它 php 版本也是可以运行的。

@juvenn juvenn merged commit fb1365d into master May 11, 2024
2 checks passed
@juvenn juvenn deleted the fix/require-phone branch May 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants