Refactor updateStopRules and add tests

[forsaken628]

What this PR does / why we need it:

Reorganize the scattered status. Add tests.
There should be a bug here. Step will be less than zero.

katib/cmd/metricscollector/v1beta1/file-metricscollector/main.go

Lines 360 to 365 in f8b8d8d

	if _, ok := metricStartStep[rule.Name]; ok {
	metricStartStep[rule.Name]--
	if metricStartStep[rule.Name] != 0 {
	return stopRules, optimalObjValue
	}
	}

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

• Docs included if any changes are user facing

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andreyvelich]

There should be a bug here. Step will be less than zero.

Thank you for refactoring these functions and add tests @forsaken628!
Please can you explain the use-case when step will be less than zero and why we don't catch this bug in our E2Es ?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.