Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KF 1.9 release blog post v1 #150

Merged

Conversation

_posts/2024-07-22-kubeflow-1.9-release.md Outdated Show resolved Hide resolved
_posts/2024-07-22-kubeflow-1.9-release.md Outdated Show resolved Hide resolved
_posts/2024-07-22-kubeflow-1.9-release.md Outdated Show resolved Hide resolved
_posts/2024-07-22-kubeflow-1.9-release.md Outdated Show resolved Hide resolved
@tarilabs
Copy link
Member

tarilabs commented Jul 9, 2024

btw, not sure if it's only my experience, but looking at the draft preview, all links are not displayed with underline/blue colour, only after clicking on them 🧐 🤔
it is very likely totally unrelated to this PR itself, but thought about mentioning it?

Screenshot 2024-07-09 at 07 32 33

@StefanoFioravanzo
Copy link
Member Author

@tarilabs thanks! It's the first time I publish a blob here so I don't know what's causing this. I'll clean up a few things, turn this into an open PR and then we'll figure this out.

@tarilabs
Copy link
Member

@tarilabs thanks! It's the first time I publish a blob here so I don't know what's causing this. I'll clean up a few things, turn this into an open PR and then we'll figure this out.

I later investigated further, appears to be an issue with the blog unrelated by this PR, worth imho to be followed-up separately my2c

StefanoFioravanzo and others added 9 commits July 12, 2024 17:23
Signed-off-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
Co-authored-by: Yuan Tang <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
Co-authored-by: Yuan Tang <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
@jbottum
Copy link
Contributor

jbottum commented Jul 23, 2024

@StefanoFioravanzo I made a few suggestions, small changes. IMO, the getting started link does need to be fixed before approval. I have not checked all of the links from within the post...I think they help but there are a lot of them.

@jbottum jbottum closed this Jul 23, 2024
@jbottum jbottum reopened this Jul 23, 2024
@jbottum
Copy link
Contributor

jbottum commented Jul 23, 2024

sorry about the faulty closure. Let me know if my action caused any issues.

Signed-off-by: Stefano Fioravanzo <[email protected]>
@StefanoFioravanzo
Copy link
Member Author

StefanoFioravanzo commented Jul 23, 2024

@jbottum what do you mean by "fixing the getting started link?" It does point to our docs getting started page

EDIT - Ah you mean the 1.9 getting started. Yes that's our only blocker

@jbottum
Copy link
Contributor

jbottum commented Jul 23, 2024

@StefanoFioravanzo @terrytangyuan @andreyvelich are we good to approve this ? It looks pretty close. I like putting in the names of the GSOC students. We could add it later. The post is long so we might find that we need some corrections after posting.

@andreyvelich
Copy link
Member

@StefanoFioravanzo @terrytangyuan @andreyvelich are we good to approve this ? It looks pretty close. I like putting in the names of the GSOC students. We could add it later. The post is long so we might find that we need some corrections after posting.

I think, we should add the GSoC students to this blog post before publishing. It should be very simple change

@rareddy
Copy link

rareddy commented Jul 24, 2024

Signed-off-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Stefano Fioravanzo <[email protected]>
@StefanoFioravanzo
Copy link
Member Author

Added GSoC students list and link

@rimolive
Copy link
Member

@andreyvelich @jbottum @terrytangyuan I think all the review comments were addressed. Let us know if we can approve and finally announce the big news.

@jbottum
Copy link
Contributor

jbottum commented Jul 24, 2024

/lgtm

@andreyvelich
Copy link
Member

Thanks @StefanoFioravanzo
/lgtm

@jbottum
Copy link
Contributor

jbottum commented Jul 24, 2024

/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbottum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 40da442 into kubeflow:master Jul 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants