-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual Input #9139
Open
ggpwnkthx
wants to merge
27
commits into
keystonejs:main
Choose a base branch
from
Esquire-Media:pr-virtual-input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Virtual Input #9139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync to remote
- `useFieldForeignListKey` now provides in `foreignLabelPath` - Virtual field type view `tags` now has a `ComponentWrapper`, rendering conditionally - `ComponentWrapper` handles updating the `value` state, as well as formatting the data for its components - `AutocompleteSelect` now builds the gql DocumentNode in the query, based on props `listKey` and `fieldPath`
virtual input
history sync development
- Added custom `Orderable` component with polished CSS to mimic the Keystone theme
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b66e4eb:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core changes made so that
virtual
field types can now handle generic JSON input values that can be used by their respective hooks.The
virtual-field
example has also been updated to show the use case of where Tag records, as they relate to Post records, are orderable. Thetags
field of the Post list will output the Tag records in the order specified by first querying the explicit relationship list, PostTags. If an array of Tag records are provided in thetags
field of a Post mutation, whatever order they are in is how they will be reordered for that Post.