Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cors.js #4650

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update cors.js #4650

wants to merge 2 commits into from

Conversation

ijmccallum
Copy link

@ijmccallum ijmccallum commented Jun 3, 2018

Description of changes

Added another cors header setting, following the pattern of the others in this file.
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#Access-Control-Allow-Credentials

The only valid value for this header is true, so I've not added in a "keystone.get('cors allow credentials')" bit like in the 'methods' and 'headers' settings.

Hopefully that seems ok!

Related issues (if any)

Add Access-Control-Allow-Credentials header to cors middleware #4380

Testing

  • Please confirm npm run test-all ran successfully.

Add Access-Control-Allow-Credentials header to cors middleware keystonejs#4380
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#Access-Control-Allow-Credentials

The only valid value for this header is true, so I've not added in a "keystone.get('cors allow credentials')" bit like in the 'methods' and 'headers' settings.

Hopefully that seems ok!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants