Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4480 - Added listening for ctrl+s in EditForm #4490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zacharysang
Copy link
Contributor

Description of changes

Added a listener for keypress event on the EditForm component. This listener checks that ctrl+s keys are pressed and if so, triggers the updateItem (save) function.

Related issues (if any)

#4480

Testing

  • Please confirm npm run test-all ran successfully.

@stennie
Copy link
Contributor

stennie commented Jun 29, 2018

@zacharysang Apologies for the delayed feedback.

Can you confirm which browser(s) you tested this with?

This appears to be work with Firefox 61.0 (macOS) but doesn't override the default key event when I tested in Chrome 67.0.3396.87 (macOS).

Thanks,
Stennie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants