Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements file-upload via dropzone #2501

Closed
wants to merge 2 commits into from
Closed

Implements file-upload via dropzone #2501

wants to merge 2 commits into from

Conversation

jacargentina
Copy link
Contributor

This fixes #2071.

It adds dropzone js library; and also updates boostrap-markdown to v2.9.0
Also includes font-awesome for the bootstrap-markdown icons.

@mxstbr
Copy link
Collaborator

mxstbr commented Mar 23, 2016

We've already got Octicons in Keystone, why do we need another icon pack?

@jacargentina
Copy link
Contributor Author

I was trying to use upstream bootstrap-mardown. That implies not doing nasty hacks.

From bootstrap-markdown docs:

The icon library to use. Glyphicons (glyph) and Font Awesome (fa) are supported. In order to use Font Awesome properly, you'll need to include Font Awesome stylesheet yourself. Default to glyph

Maybe you would like to PR on them with adding octicons as an option?

@mxstbr
Copy link
Collaborator

mxstbr commented Mar 23, 2016

I don't think sending down another icon set just to get drag-n-drop upload working is worth it. As much as we appreciate you taking the time to submit this PR, if there's a solution without font awesome that'd be a lot better!

@mxstbr mxstbr closed this Mar 23, 2016
@jacargentina
Copy link
Contributor Author

It serves my need. The branch will be there as reference on my fork if someody really needs it (just works)

Cheers!

@mxstbr
Copy link
Collaborator

mxstbr commented Mar 23, 2016

Awesome, that's great to hear! We really appreciate you taking the time to implement this, sorry if I came off a bit harsh. 👍

@jacargentina
Copy link
Contributor Author

@mxstbr
Please look at this elementalui/elemental#146 which depends also on refactory-id/bootstrap-markdown#232

New PR is keystonejs/keystone#2508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement markdown "file upload" feature
2 participants