Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass query args to list access control functions #420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SavelevMatthew
Copy link

@SavelevMatthew SavelevMatthew commented Feb 29, 2024

Hi!

We are using keystone-v5 in our open source condominium management software.

We recently encountered the following problem. We want to prevent a certain group of users from filtering on a certain set of fields in queries.

It turned out that unlike CustomProvider, ListProvider does not pass query arguments to the access control function, so it becomes impossible to analyse the where argument.

This fix passes query arguments to the access control function, making it possible to analyze arguments when evaluating accesses.

You can find more details inside this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant