Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/doc-sftp-key-file-pem-format #67

Merged
merged 2 commits into from
Aug 1, 2023
Merged

fix/doc-sftp-key-file-pem-format #67

merged 2 commits into from
Aug 1, 2023

Conversation

brian-mulier-p
Copy link
Member

closes #66

@brian-mulier-p brian-mulier-p self-assigned this Aug 1, 2023
Skraye
Skraye approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anna-geller
anna-geller approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@anna-geller anna-geller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, just a tiny nitpick

@brian-mulier-p brian-mulier-p merged commit d3fda81 into master Aug 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skraye Skraye Skraye approved these changes

@anna-geller anna-geller anna-geller approved these changes

@loicmathieu loicmathieu Awaiting requested review from loicmathieu

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that our implementation of FTP (JSCH) doesn't support non-PEM format
3 participants
@brian-mulier-p @Skraye @anna-geller