Added option not to compile python files #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasBackx
reviewed
Jan 7, 2020
There was a problem hiding this comment.
LGTM with the changes I mentioned, but gonna leave the final review to @jrief. Thank you for your PR.
PS: In the future please use a different branch name for your PR. See https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests.
| action='store_true', | ||
| dest='exclude_py', | ||
| default=False, | ||
| help=_("Exclude python files from scan?") |
There was a problem hiding this comment.
Nitpick: perhaps change question mark to dot.
There was a problem hiding this comment.
Rather, no punctuation mark at all.
|
@askvortsov1 which use-case does this feature have? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.