Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature: Per type newLine separator #263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GusGold
Copy link

@GusGold GusGold commented Apr 25, 2020

Allows providing an object to options.newLine to specify a file separator based on the file type. e.g. Joining js types with a semicolon and newline, and css with just a new line:

useref({
    newLine: {
        js: ';\n',
        css: '\n'
    }
})

@coveralls
Copy link

coveralls commented Apr 25, 2020

Coverage Status

Coverage increased (+0.02%) to 98.204% when pulling 4cc0edc on GusGold:master into 5a632ab on jonkemp:master.

@GusGold
Copy link
Author

GusGold commented Apr 28, 2020

Hey @jonkemp

Please take a look at this PR when you get a chance. Thanks.

@GusGold
Copy link
Author

GusGold commented May 5, 2020

A friendly reminder to take a look at this PR @jonkemp

@jonkemp
Copy link
Owner

jonkemp commented May 5, 2020

Thank you for your interest. I am maintaining this project but not actively developing it. Pull requests are still welcome but a pull request that implements a new feature is going to take some convincing to add. I am not currently convinced that there is enough interest in this feature to warrant adding it at this time. That said I am more than happy to leave it open for feedback. If there is sufficient interest in this PR from others, I will reconsider it then.

@GusGold
Copy link
Author

GusGold commented May 10, 2020

Okay, no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants