Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Facebook- and Twittter-login #923

Merged

Conversation

Sjors1985
Copy link

This PR contains removals for Twitter / X- and Facbook-login for creating an account. Both functions aren't working properly.

Closes #922

Sidenote: This is my first PR ever, so if you have feedback to optimize it, please let me know.

@Sjors1985 Sjors1985 changed the title 922 removed twitter facebook login Remove Facebook- and Twittter-login Mar 29, 2024
@heiglandreas
Copy link
Member

This looks really goot! Thank you for your contribution.

I will give it a test oater today but do currently not see any issues.

@Sjors1985
Copy link
Author

Hi,

I was wondering if you had already tested my code. And I also detected my commits are Unverified. Is that okay for you?

@heiglandreas
Copy link
Member

The unverified is OK (After all it's only deleting code 😁)

I have not yet managed to give it a go. It's planned for this weeek 🙈

@Sjors1985
Copy link
Author

Thanks for your response! :)

I'm going to check why my commits aren't verified

@afilina
Copy link

afilina commented Apr 23, 2024

It's planned for this weeek 🙈

@heiglandreas Bump.

Copy link
Member

@heiglandreas heiglandreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not break anything. Local tests worked fine.

@heiglandreas heiglandreas merged commit e444670 into joindin:master Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to join using Twitter/Facebook
3 participants